Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave font whitelist needs unit tests #22177

Closed
pilgrim-brave opened this issue Apr 8, 2022 · 0 comments · Fixed by brave/brave-core#12952
Closed

Brave font whitelist needs unit tests #22177

pilgrim-brave opened this issue Apr 8, 2022 · 0 comments · Fixed by brave/brave-core#12952
Assignees
@pilgrim-brave
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.42.x - Release

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Apr 8, 2022 •
edited
Loading

  • known fonts (per platform)
  • default for CanRestrict (per platform)
  • number of fonts in each list (per platform)
  • add set_for_testing function and test API functions
@pilgrim-brave pilgrim-brave self-assigned this Apr 8, 2022
@pilgrim-brave pilgrim-brave mentioned this issue Apr 8, 2022
Merged
25 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Jun 22, 2022
@bsclifton
Revert unit tests
02204a7 
Reverts #12952
Which fixed brave/brave-browser#22177

Reverts #12942
Which fixed brave/brave-browser#21985
@bsclifton bsclifton mentioned this issue Jun 22, 2022
Closed
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 22, 2022
@pilgrim-brave pilgrim-brave added QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.42.x - Release
3 participants
@rebron @pilgrim-brave @brave-builds