Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BraveFarblingService needs unit tests #21985

Closed
pilgrim-brave opened this issue Mar 30, 2022 · 0 comments · Fixed by brave/brave-core#12942
Closed

BraveFarblingService needs unit tests #21985

pilgrim-brave opened this issue Mar 30, 2022 · 0 comments · Fixed by brave/brave-core#12942
Assignees
@pilgrim-brave
Labels
OS/Desktop QA/No release-notes/exclude
Milestone
1.42.x - Release

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Mar 30, 2022 •
edited
Loading

check MakePseudoRandomGeneratorForURL with different urls, otr/non-otr and prng values

also verify that session_token returns the expected values with and without otr

change set_session_tokens_for_testing to take two values to set so they can be changed as well

and check MakePseudoRandomGeneratorForURL with different session token values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.42.x - Release
2 participants
@pilgrim-brave @brave-builds