Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permissions-lifetime feature flag #16910

Closed
stephendonner opened this issue Jul 12, 2021 · 1 comment · Fixed by brave/brave-core#9448
Closed

Remove permissions-lifetime feature flag #16910

stephendonner opened this issue Jul 12, 2021 · 1 comment · Fixed by brave/brave-core#9448
Assignees
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Remove permissions-lifetime feature flag

Steps to Reproduce

  1. new profile
  2. load brave://flags
  3. type lifetime

Actual result:

Even though it's on by default (from #16646), there's still a feature flag for the permissions-lifetime feature, at brave://flags/#brave-permission-lifetime

Screen Shot 2021-07-12 at 2 27 02 PM

Expected result:

There shouldn't be a feature flag for permissions-lifetime available at brave://flags/#brave-permission-lifetime

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.74 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

/cc @goodov

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". feature/global-settings Settings at browser level independent of shields settings labels Jul 15, 2021
@goodov goodov self-assigned this Jul 16, 2021
@goodov goodov added this to the 1.29.x - Nightly milestone Jul 16, 2021
@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.29.8 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://flags
  4. search for lifetime
  5. load https://permission.site/ and click on Location
  6. confirmed the permission was granted to https://permission.site/ for location via site info
example example
Screen Shot 2021-07-19 at 5 01 50 PM Screen Shot 2021-07-19 at 5 05 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants