Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PermissionLifetime feature from brave://flags. #9448

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 15, 2021

Resolves brave/brave-browser#16910

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested review from iefremov and yrliou July 15, 2021 13:55
@goodov goodov requested a review from a team as a code owner July 15, 2021 13:55
@goodov goodov requested a review from mariospr July 16, 2021 09:36
Copy link
Contributor

@mariospr mariospr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the point of view of removing this from brave://flags.

However, I do have a question on whether we want to keep the feature itself available and enabled by default instead of simply dropping it entirely and adapting the code that does base::FeatureList::IsEnabled() and simply assume true everywhere.

Is is because we still want to be able to disable it from the command line for testing/devel purposes?

@goodov
Copy link
Member Author

goodov commented Jul 16, 2021

Is is because we still want to be able to disable it from the command line for testing/devel purposes?

I'd like to keep it for some time to be able to disable it via Griffin if something pops up.

@goodov goodov merged commit e62631a into master Jul 16, 2021
@goodov goodov deleted the issues/16910 branch July 16, 2021 10:33
@goodov goodov added this to the 1.29.x - Nightly milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove permissions-lifetime feature flag
3 participants