Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow whitelisted protocols in tor mode #1378

Closed
jumde opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#583
Closed

Only allow whitelisted protocols in tor mode #1378

jumde opened this issue Oct 1, 2018 · 3 comments · Fixed by brave/brave-core#583
Assignees
@yrliou @riastradh-brave
Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking security
Milestone
0.55.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Oct 1, 2018

brave/browser-laptop#14664
brave/browser-laptop#14665
@jumde jumde added the feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. label Oct 1, 2018
@jumde jumde mentioned this issue Oct 1, 2018
Closed
@diracdeltas
Copy link
Member

I just remembered this led to an easy IP proxy bypass on MacOS, so it should be marked as release blocking.

@diracdeltas diracdeltas added this to the Releasable builds 0.55.x milestone Oct 1, 2018
@diracdeltas diracdeltas changed the title Allow whitelisted protocols in tor mode Only allow whitelisted protocols in tor mode Oct 1, 2018
@riastradh-brave riastradh-brave self-assigned this Oct 3, 2018
@yrliou yrliou self-assigned this Oct 4, 2018
@yrliou yrliou mentioned this issue Oct 9, 2018
Merged
18 tasks
@yrliou yrliou added the QA/Yes label Oct 9, 2018
@yrliou
Copy link
Member

yrliou commented Oct 9, 2018

Test plan specified in brave/brave-core#583

@btlechowski
Copy link

btlechowski commented Oct 10, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Used test plan from brave/brave-core#583

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Verified passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

This was referenced Jul 12, 2021
Open
Closed
Closed
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Jul 13, 2021
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 13, 2021
Closed
@bsclifton bsclifton mentioned this issue Jul 13, 2021
Closed
This was referenced Jul 13, 2021
Closed
Closed
This was referenced Jul 13, 2021
Open
Closed
@melo936 melo936 mentioned this issue Jul 14, 2021
Closed
This was referenced Jul 14, 2021
Closed
Closed
Closed
This was referenced Jul 15, 2021
Closed
Closed
Closed
Closed
This was referenced Jul 15, 2021
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 16, 2021
Closed
This was referenced Jul 20, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

@riastradh-brave riastradh-brave

Labels
browser-laptop-parity feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking security
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Only allow whitelisted protocols to load in Tor brave/brave-core
7 participants
@diracdeltas @jumde @yrliou @srirambv @LaurenWags @riastradh-brave @btlechowski