Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BAP translations #14572

Closed
LaurenWags opened this issue Mar 8, 2021 · 2 comments · Fixed by brave/brave-core#8181
Closed

Update BAP translations #14572

LaurenWags opened this issue Mar 8, 2021 · 2 comments · Fixed by brave/brave-core#8181

Comments

@LaurenWags
Copy link
Member

Description

BAP popup/modal translations have been updated, see https://github.com/brave/internal/issues/756

Updated translations should be in Transifex per above issue, this is a placeholder so QA verifies them.

Steps to Reproduce

  1. Trigger BAP modal
  2. Confirm English and Japanese text.

cc @Miyayes @kjozwiak @rebron @bsclifton

@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
-- | --
Revision | 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS | Windows 10 OS Version 2009 (Build 19042.844)

Verified the STR/Case outlined via #14572 (comment) and ensured that the translations mentioned via https://github.com/brave/internal/issues/756#issue-824795329 are being used. Found https://github.com/brave/internal/issues/756#issuecomment-796417618 but not a blocker.

English Japanese
image japanModal

Verified passed with

Brave	1.21.76 Chromium: 89.0.4389.86 (Official Build) (x86_64)
Revision	0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS	macOS Version 10.15.7 (Build 19H524)

Verified the STR/Case outlined via #14572 (comment) and ensured that the translations mentioned via https://github.com/brave/internal/issues/756#issue-824795329 for the BAP alert are being used. (Note, per discussions, time for tooltip has passed, those translations were not verified)

English Japanese
English Japanese

Verification passed on

Brave 1.21.76 Chromium: 89.0.4389.86 (Official Build) (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS

Verified test plan from #14572 (comment) and ensured that the translations mentioned via https://github.com/brave/internal/issues/756#issue-824795329 are being used

image
image

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.21.76 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment