-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAP popup and alert need Japanese translations #14117
Comments
@deeppandya If language is Japanese, these are the translated strings: Little Tooltip Brave Rewards in Japan is switching to a new system! Please use your BAP by March 13th. After that, BAP will be discontinued. [Learn more] 日本でのBrave Rewardsが新システムに移行します! [詳しくはこちら] Full dialog box: Brave Rewards in Japan is switching to a new system! The tipping feature will be unavailable from March 13th until April 13th. All BAPs will be discontinued by April 13th. Please use your BAP by March 13th. Any BAP remaining in your Brave browser after March 13th cannot be held or transferred by you or Brave, and will be lost. A new and improved system awaits! 日本でのBrave Rewardsが新システムに移行します! 3月13日から4月13日チップを送る機能が停止されます。すべてのBATポイント(BAP)は4月13日に廃止されます。 改良された新システムへの移行をご期待ください! |
Closing as brave/brave-core#7949 was merged into |
Verification passed on
Verification passed on
Verified
|
Removing |
Moving this into |
Verification PASSED on
Verified passed with
Verification passed on
|
Description
Found while testing brave/brave-core#7698
The BAP popup and alert display in English even if the OS language is Japanese.
Steps to Reproduce
Actual result:
English text for both:
Expected result:
Japanese translations for that text
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @zenparsing @bsclifton @Miyayes @brave/legacy_qa
The text was updated successfully, but these errors were encountered: