Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations for BAP deprecation tooltip and modal #14220

Closed
srirambv opened this issue Feb 17, 2021 · 3 comments
Closed

Missing translations for BAP deprecation tooltip and modal #14220

srirambv opened this issue Feb 17, 2021 · 3 comments
Assignees
Labels
feature/rewards l10n OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

#14117 fixed translations on desktop. We need the same translations for Android as well.

Steps to reproduce

  1. Install 1.20.104 in Japanese locale
  2. Trigger BAP deprecation modals
  3. None of them are translated

Actual result

image image

Expected result

Translated strings

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.20.104

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@bsclifton
Copy link
Member

Fixed with brave/brave-core#7983

@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.21.76 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards l10n OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants