BREAKING CHANGE: Change IDs from int -> int64. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes ghinstallation consistent with `github.com/google/go-github` for App and Installation identifiers. See google/go-github#597 for related discussion. Fixes bradleyfalzon#27
| @@ -63,7 +63,7 @@ func (t *AppsTransport) RoundTrip(req *http.Request) (*http.Response, error) { | |||
| claims := &jwt.StandardClaims{ | |||
| IssuedAt: time.Now().Unix(), | |||
| ExpiresAt: time.Now().Add(time.Minute).Unix(), | |||
| Issuer: strconv.Itoa(t.appID), | |||
| Issuer: strconv.FormatInt(t.appID, 10), | |||
There was a problem hiding this comment.
I'm OK with this, but what was the reason for this change?
There was a problem hiding this comment.
Itoa is only for int. FormatInt is the int64 equivalent. See https://godoc.org/strconv#Itoa
There was a problem hiding this comment.
oh of course, I only looked at the return parameters, not the arguments.
|
This looks good to me, I'll merge, and anyone using any kind of pinning shouldn't be affected (they'll still be using 0.1.2) until we tag it. |
bradleyfalzon
approved these changes
Oct 9, 2019
grauwoelfchen
added a commit
to grauwoelfchen/reviewdog
that referenced
this pull request
Oct 25, 2019
The type of IDs (integrationID and installationID) have been updated by a following PR on ghinstallation project: bradleyfalzon/ghinstallation#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes ghinstallation consistent with
github.com/google/go-githubfor App and Installation identifiers. Seegoogle/go-github#597 for related discussion.
Fixes #27