-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type mismatch with third-party library method parameter #28
Comments
This looks like a recent breaking change introduced upstream: bradleyfalzon/ghinstallation#30. As a quick fix, I'd suggested pinning the dependency version to If that's not possible, and as a long-term fix, updating this library makes sense, so a PR is welcome if you want. I think it might require the same breaking change to our API, since we use an |
@bluekeyes Done. Let me know if you'd like that PR and I can definitely open it (with the knowledge that it's a breaking change as you mentioned). |
I looked into this more and I think upgrading We discussed modules a bit in #9, but didn't reach a conclusion. In addition to the problems raised on that issue, adopting modules here I think will require us to release major versions in lockstep with For now, I added a constraint on |
Description
It looks like there's a conflict between this library and the
bradleyfalzon/ghinstallation
library:This pops up when I attempt to build my project which uses the
go-githubapp
library. I assume the fix here is to change the type of the value passed into thoseghinstallation.NewAppsTransport
andghinstallation.New
methods to beint64
to comply with that library's requirements? If so, I can open a PR to address it - just let me know!The text was updated successfully, but these errors were encountered: