Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load icons as html #1920

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Load icons as html #1920

merged 3 commits into from
Jun 5, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jun 5, 2023

Close #1918

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 5, 2023
@smbea smbea force-pushed the load-icon-as-html branch from eb7beb7 to 8f8cd5b Compare June 5, 2023 09:01
@smbea smbea requested review from nikku and barmac June 5, 2023 09:18
@smbea smbea marked this pull request as ready for review June 5, 2023 09:25
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 5, 2023
marstamm
marstamm approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

We are inconsistent with imageHtml and html as @barmac mentioned, but I think we can keep it for now and can consider aligning it at a later point

@smbea smbea merged commit 35a45ac into develop Jun 5, 2023
@smbea smbea deleted the load-icon-as-html branch June 5, 2023 12:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac left review comments

@marstamm marstamm marstamm approved these changes

@nikku nikku Awaiting requested review from nikku

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow html pattern for icon loading
3 participants
@smbea @marstamm @barmac