Follow html pattern for icon loading

[smbea]

What should we do?

Replace instances where we use "embedded icons" and replace it with html, like bpmn-io/bpmn-js-create-append-anything#7

Why should we do it?

To establish a single pattern and be consistent across our stack

[smbea]

The instances of "embedded icons" in bpmn-js are the align and distribute icons. The icons that are rendered with the popup menu can't be changed as easily.

Firstly we need to allow html in diagram-js popup menu component, which we currently don't.

Then there is challenge with using htm's html`...` utility. In previous cases, we would pass html: "<div>some html string</div>", and we would domify it and add it to the tree. With popup menu, I'm having trouble rendering this in the htm context.

What I can imagine works is using the html`...` utility in bpmn-js but that would introduce differ from non-popup menu places.

[nikku]

What keeps us from using dangerouslySetInnerHTML? I believe it should work with htm, too?

[smbea]

Nothing. That did the trick, thanks!