Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow TextAnnotation for SequenceFlows #1652

Merged
merged 4 commits into from
May 20, 2022
Merged

feat: allow TextAnnotation for SequenceFlows #1652

merged 4 commits into from
May 20, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented May 18, 2022 •
edited
Loading

@marstamm marstamm self-assigned this May 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 18, 2022
@marstamm marstamm force-pushed the connection-association branch 2 times, most recently from b34cefa to 3ca843d Compare May 19, 2022 14:33
@marstamm marstamm marked this pull request as ready for review May 19, 2022 15:14
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 19, 2022
@marstamm marstamm requested review from a team, pinussilvestrus and Skaiir and removed request for a team May 19, 2022 15:14
@marstamm marstamm force-pushed the connection-association branch from 3ca843d to 0ebc1cc Compare May 19, 2022 15:17
pinussilvestrus
pinussilvestrus suggested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a bit around and discovered the positioning is not working properly in some cases

Kapture 2022-05-20 at 11 08 06

lib/features/modeling/behavior/LayoutConnectionBehavior.js Show resolved Hide resolved
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 20, 2022
@marstamm
Copy link
Contributor Author

That's weird, It does not work for me now either. I'm 100% certain I tested this before 😅

I'll check if something broke during rebasing or something

@marstamm marstamm force-pushed the connection-association branch from 0ebc1cc to c7157d5 Compare May 20, 2022 09:33
@marstamm
Copy link
Contributor Author

Should be fixed. I messed up going from spread operators to ES5 Code 🙈

@marstamm marstamm requested a review from pinussilvestrus May 20, 2022 09:35
pinussilvestrus
pinussilvestrus approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wasn't able to break it anymore :) Good job! 👏

@fake-join fake-join bot merged commit 9737708 into develop May 20, 2022
@fake-join fake-join bot deleted the connection-association branch May 20, 2022 10:00
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@Skaiir Skaiir Awaiting requested review from Skaiir Skaiir was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marstamm @pinussilvestrus