Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can add a text annotation to a sequence flow #402

Open
falko opened this issue Aug 18, 2016 · 5 comments
Open

I can add a text annotation to a sequence flow #402

falko opened this issue Aug 18, 2016 · 5 comments
Labels
backlog Queued in backlog BPMN enhancement New feature or request hacktoberfest modeling spring cleaning Could be cleaned up one day

Comments

@falko
Copy link
Member

falko commented Aug 18, 2016

Is your feature request related to a problem? Please describe.

Currently, text annotations can't be added to sequence flows. It is allowed by the BPMN 2.0 spec, though:

image

Describe the solution you'd like

Make it possible to connect and add text annotations to a sequence flow.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

This has to be added to bpmn-js (rules and context pad action).

@nikku nikku added BPMN modeling enhancement New feature or request labels Aug 22, 2016
@nikku nikku added this to the Backlog milestone Aug 22, 2016
@davidrwerner
Copy link

Number one reason I'm avoiding using Camunda fyi. My colleagues and I would prefer to create and pass distribute proposed flows but there's no easy way to add feedback within the spec itself.

@falko
Copy link
Member Author

falko commented Jun 12, 2017

You could also work with the document attribute.

@nikku nikku added the backlog Queued in backlog label Feb 14, 2018
@nikku nikku removed this from the Backlog milestone Feb 14, 2018
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Feb 28, 2020
@nikku nikku removed the easy label Dec 8, 2020
@barmac barmac assigned barmac and unassigned barmac Jan 18, 2021
@barmac
Copy link
Collaborator

barmac commented Jan 19, 2021

I tried to implement this but then discovered that it's too complex for spring cleaning. We can tackle this later but need to make sure that we don't introduce bugs.

In bpmn-js, it's easy:

However, this requires also a new concept in diagram-js: connecting connections.
In diagram-js, there are two basic types of objects: shapes and connections. The layouting utils are built on an assumption that we always connect shapes with each other. In this case, however, we need to connect a Text Annotation to a Sequence Flow. This breaks the assumption and leads to errors.

I am afraid that even if I implement it now, we may expect crashes in some other places where we take the same assumption but which I haven't discovered yet.

@falko
Copy link
Member Author

falko commented Jan 19, 2021

@barmac thanks for giving it a try. This limitation of diagram-js will also affect the implementation of #1707.

@jurgenhaas
Copy link

We'd be interested in this enhancement too. The mentioned workaround with the document attribute doesn't work for us, as we use templates and as soon as a template is assigned, the document attribute disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog BPMN enhancement New feature or request hacktoberfest modeling spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

6 participants