Support modeling of collapsed subprocesses #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
force-pushed
the
1539-collapse-expand
branch
2 times, most recently
from
1dbfd76 to
b68f5fd
Compare
marstamm
force-pushed
the
1539-collapse-expand
branch
2 times, most recently
from
587408a to
72e4f67
Compare
marstamm
changed the title
marstamm
force-pushed
the
1539-collapse-expand
branch
from
72e4f67 to
c7b8bb6
Compare
bpmn-io-tasks
bot
added
needs review
nikku
requested changes
Jan 4, 2022
test/spec/features/modeling/behavior/SubProcessPlaneBehaviorSpec.js
Outdated
Show resolved
Hide resolved
|
|
||
| // old plane could have content, | ||
| // we remove it so it is not recursively deleted from 'shape.delete' | ||
| context.oldRoot = canvas.removeRootElement(planeId(oldShape)); |
There was a problem hiding this comment.
Shall we not modeling#removeRoot here?
There was a problem hiding this comment.
That would imply that we move the children first before removing the root.
|
Played around with the implementation and could not break it, too. Just found #1564 (but was not quickly able to figure out where on |
|
Fixed the markers upstream: bpmn-io/diagram-js#609 |
nikku
approved these changes
Jan 12, 2022
nikku
reviewed
Jan 12, 2022
| // do not resize plane elements: | ||
| // root elements, collapsed sub-processes | ||
| if (is(target.di, 'bpmndi:BPMNPlane')) { | ||
| return false; |
There was a problem hiding this comment.
We do have test to verify this, correct? I.e. creating or moving elements on a root element?
|
Found a follow up issue: #1565. |
|
Found another follow up issue: #1566. |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First up: sorry for the big Pull Request. With the new diagram-js API I had to rework all Behaviors to work accordingly. I already have them ready and they build on each other, so I decided to just create one big PR. I tried to split the work into into sensible commits to make reviewing a bit easier.
This PR fixes 3 Things listed in #1443 :
If you want, we can also have a quick call and I can give you an overview of the changes.
closes #1511
closes #1536
closes #1539