Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment markers disappeared on develop #1564

Closed
nikku opened this issue Jan 10, 2022 · 1 comment
Closed

Alignment markers disappeared on develop #1564

nikku opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Jan 10, 2022

Describe the Bug

With bpmn-js@develop the alignment markers disappeared from the canvas, leaving me clueless what element I'm currently snapping the selected element to:

capture ClKWHS_optimized

Steps to Reproduce

  1. Checkout bpmn-js@develop
  2. Run npm start
  3. Try to align two elements

Expected Behavior

Alignment marker appears as on the released bpmn-js version:

capture zLnro7_optimized

Environment

  • Browser: Chrome 99
  • OS: Linux
  • Library version: bpmn-js@develop
@nikku nikku added the bug Something isn't working label Jan 10, 2022
@nikku nikku mentioned this issue Jan 10, 2022
Merged
@nikku
Copy link
Member Author

nikku commented Jan 10, 2022

Root caused the issue; we do not define a --snap-line-stroke-color variable as printed by the developer tools, too:

capture kFgmou_optimized

@nikku nikku added good first issue Good for newcomers ready Ready to be worked on spring cleaning Could be cleaned up one day labels Jan 10, 2022
marstamm added a commit to bpmn-io/diagram-js that referenced this issue Jan 10, 2022
@marstamm
fix(snapping): use existing color variable
8e48c6e 
related to bpmn-io/bpmn-js#1564
@marstamm marstamm mentioned this issue Jan 10, 2022
Merged
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 10, 2022
@marstamm @fake-join
fix(snapping): use existing color variable
8915a3c 
related to bpmn-io/bpmn-js#1564
@nikku nikku added the fixed upstream Requires integration of upstream change label Jan 10, 2022
@pinussilvestrus pinussilvestrus removed the ready Ready to be worked on label Jan 11, 2022
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 11, 2022
@marstamm @nikku
fix(snapping): use existing color variable
2a32d1c 
related to bpmn-io/bpmn-js#1564
@nikku nikku closed this as completed in 93fb071 Jan 14, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @pinussilvestrus