Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modeling#updateModdleProperties does not add label for events name modification #1872

Closed
barmac opened this issue Mar 21, 2023 · 4 comments · Fixed by #1894
Closed

Modeling#updateModdleProperties does not add label for events name modification #1872

barmac opened this issue Mar 21, 2023 · 4 comments · Fixed by #1894
Assignees
@barmac
Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented Mar 21, 2023

Describe the Bug

When I call modeling.updateModdleProperties in order to change element's name, the label is not created.

Steps to Reproduce

https://codesandbox.io/s/relaxed-kilby-4bh0xi?file=/src/index.js

Expected Behavior

Label is added as with modeling.updateProperties.

Environment

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@barmac barmac added bug Something isn't working modeling backlog Queued in backlog spring cleaning Could be cleaned up one day labels Mar 21, 2023
This was referenced Mar 21, 2023
Closed
Closed
@nikku nikku changed the title Modeling#updateModdleProperties does not add label for events name modification Modeling#updateModdleProperties does not add label for events name modification Mar 21, 2023
@barmac barmac self-assigned this Mar 31, 2023
@barmac barmac added ready Ready to be worked on and removed backlog Queued in backlog labels Mar 31, 2023
@barmac
Copy link
Member Author

barmac commented Apr 11, 2023

In the process of BPMN MIWG demo preparations, we discovered that this bug applies also to Tasks. We do not create even empty <bpmndi:BPMNLabel> which results in interchange problems. Some tools follow the spec strictly, i.e. they don't display name if DI label is missing.

@barmac
Copy link
Member Author

barmac commented Apr 17, 2023

One more bug related to this: We don't remove BPMNLabel when name is erased via modeling.updateProperties in external label elements.

@barmac
Copy link
Member Author

barmac commented Apr 19, 2023

Architecture sketch:

image

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Apr 19, 2023
barmac added a commit that referenced this issue Apr 19, 2023
@barmac
fix: update label on modeling.updateModdleProperties
d633a63 
Closes #1872
This was referenced Apr 19, 2023
Open
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Apr 19, 2023
barmac added a commit that referenced this issue Apr 20, 2023
@barmac
fix: update label on modeling.updateModdleProperties
4389968 
Closes #1872
nikku pushed a commit that referenced this issue Apr 24, 2023
@barmac @nikku
fix: update label on modeling.updateModdleProperties
881e2bd 
Closes #1872
@barmac
Copy link
Member Author

barmac commented Apr 25, 2023

Fixed via #1894

@barmac barmac closed this as completed Apr 25, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working modeling spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update label on modeling.updateModdleProperties bpmn-io/bpmn-js
1 participant
@barmac