Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPMNLabel is not removed when name is erased on an external label element #1893

Open
barmac opened this issue Apr 19, 2023 · 4 comments
Open

BPMNLabel is not removed when name is erased on an external label element #1893

barmac opened this issue Apr 19, 2023 · 4 comments
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Member

barmac commented Apr 19, 2023 

          One more bug related to this: We don't remove BPMNLabel when name is erased via `modeling.updateProperties` in external label elements.

Originally posted by @barmac in #1872 (comment)
@barmac barmac added bug Something isn't working good first issue Good for newcomers backlog Queued in backlog spring cleaning Could be cleaned up one day labels Apr 19, 2023
@barmac barmac mentioned this issue Apr 19, 2023
Merged
@Pushkarmondal
Copy link

hey, can you please tell me what I have to do?
I want to work on this.

@barmac
Copy link
Member Author

barmac commented Apr 21, 2023

Hi,

We need a test case which verifies that BPMNLabel is removed when an external label is removed, and the implementation which does it. I envision this to be implemented in the BpmnUpdater, specifically in this function: https://github.com/bpmn-io/bpmn-js/blob/1872-fix/lib/features/modeling/BpmnUpdater.js#L300 Notice that the link refers to a PR which will be probably merged soon.

@VISHESH0932
Copy link

Can i work on this issue?

@nikku
Copy link
Member

nikku commented Oct 14, 2024

@VISHESH0932 pull requests are open, happy to take a contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikku @barmac @VISHESH0932 @Pushkarmondal