Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak: Improve Flatpak manifest #3581

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

TheEvilSkeleton
Copy link
Member

@TheEvilSkeleton TheEvilSkeleton commented Dec 6, 2024

  • Move manifest to build-aux
  • Combine src file
  • Convert main manifest to json

Description

Builds on top of #3526

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.

  • Built using GNOME Builder
  • Tested via GitHub Actions

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Pylint result on modfied files:

@TheEvilSkeleton TheEvilSkeleton force-pushed the improve-flatpak branch 2 times, most recently from dcbd57d to acf9b8f Compare December 6, 2024 18:50
@TheEvilSkeleton TheEvilSkeleton mentioned this pull request Dec 6, 2024
6 tasks
- Move manifest to `build-aux`
- Combine src file
- Convert main manifest to json

Co-authored-by: underlinejakez <156628777+underlinejakez@users.noreply.github.com>
@mirkobrombin mirkobrombin merged commit 18ada3d into bottlesdevs:main Dec 7, 2024
4 checks passed
@TheEvilSkeleton TheEvilSkeleton deleted the improve-flatpak branch December 9, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants