Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local builds not being able to run 32bit programs #3526

Closed
wants to merge 2 commits into from

Conversation

underlinejakez
Copy link
Contributor

@underlinejakez underlinejakez commented Oct 13, 2024

Description

For some reason, when building locally, you can't run any 32-bit programs without org.freedesktop.Platform.Compat.i386. This solves, but its weird that it don't happen on the Flathub build.

jake@fedora:~$ flatpak run --env=LC_ALL=C --command=sh com.usebottles.bottles 
[📦 com.usebottles.bottles ~]$ wine --version
sh: /app/bin/wine: cannot execute: required file not found
[📦 com.usebottles.bottles ~]$ wine64 --version
wine-9.0
[📦 com.usebottles.bottles ~]$ /home/jake/.var/app/com.usebottles.bottles/data/bottles/runners/soda-9.0-1/bin/wine --version
sh: /home/jake/.var/app/com.usebottles.bottles/data/bottles/runners/soda-9.0-1/bin/wine: cannot execute: required file not found
[📦 com.usebottles.bottles ~]$ /home/jake/.var/app/com.usebottles.bottles/data/bottles/runners/soda-9.0-1/bin/wine64 --version
wine-experimental.bleeding.edge.9.0.93696.20240429 ( TkG Plain )

Which cause the error I shown:

/bin/sh: line 1: /app/bin/wine: cannot execute: required file not found
17:44:25 (INFO) Runners found:
	 - soda-9.0-1
	 - sys-

The problem almost gets away because of this line of code but trying to create a 32bit prefix or anything related to running 32bit quickly break and bottles interface doesn't show any sign of problem.

if arch == "win64":
runner = f"{runner}64"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I built and installed manually from master and after the modification using:
flatpak run org.flatpak.Builder --user --install-deps-from=flathub --install --force-clean build-dir com.usebottles.bottles.yml

edited to explain better the issue (i will try to rename the commit later)

@mirkobrombin
Copy link
Member

Thanks for your contribution. This is indeed weird, need to test it locally on my end

Copy link
Contributor

Pylint result on modfied files:

@underlinejakez underlinejakez changed the title fix: not being able to detect sys-wine fix: local builds not being able to run 32bit programs Nov 30, 2024
@underlinejakez
Copy link
Contributor Author

Hi, I edited the PR and commit to reflect what really is going on (hope I didn't messed up with git). I'll be happy if you could take a look again.

Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know if you have other commits before I merge

@underlinejakez
Copy link
Contributor Author

I think this is all.

@underlinejakez
Copy link
Contributor Author

Superseded by #3581.

@underlinejakez underlinejakez deleted the manifest branch December 7, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants