-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bad connections handling #3075
Improve bad connections handling #3075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a review code-wise from Mirko or another contributor that can. Otherwise, generally LGTM.
5927baa
to
e39d5bf
Compare
Pylint result on modfied files:
|
e39d5bf
to
fe98da9
Compare
I will see if I can test this myself later and land it for the next Bottles release. @koplo199 you've been pretty active recently, care to give it a review? |
SonarQube Quality Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test but the code looks good to me
Does this only affect Bottles itself (or just startup of Bottles), or does this cut ALL internet traffic, even from all bottles and programs run in them? The wording of the setting in the preferences ("Force disable any network activity even with available network connection") seems to indicate that ALL traffic is stopped. |
Description
Adds a button to skip startup connections and go to offline mode to help with Bottles startup on slow and unstable connections.
Adds "Force Offline Mode" setting in preferences/General/Advanced as option to immediately start Bottles on slow and unstable connections.
Fixes #2954 problem for me
Type of change
How Has This Been Tested?
sudo wondershaper $NET_INTERFACE 100 100
to limit your connection speedSkip button correctly handles skipping 2 stage connection pings and downloading of repositories indexes