Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account_id to credentials object #3328

Conversation

alexgromero
Copy link
Contributor

@alexgromero alexgromero commented Jan 3, 2025

Overview

This PR introduces a new optional field, account_id, to the Credentials object. The account_id will default to None if not supplied. This addition enables the retrieval of an AWS account ID during credential resolution, which will then be used in the endpoint resolution process to construct endpoints that require an account ID.
The field will be added to the following classes:

  • Credentials
  • RefreshableCredentials
  • DeferredRefreshableCredentials
  • ReadOnlyCredentials

Testing

Testing for this change will be included in upcoming related PRs.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (account-id-endpoint-routing@f1b5714). Learn more about missing BASE report.

Files with missing lines Patch % Lines
botocore/credentials.py 83.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             account-id-endpoint-routing    #3328   +/-   ##
==============================================================
  Coverage                               ?   93.17%           
==============================================================
  Files                                  ?       66           
  Lines                                  ?    14423           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    13439           
  Misses                                 ?      984           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgromero alexgromero merged commit 0effecf into boto:account-id-endpoint-routing Jan 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants