Add account ID to the environment variable credential provider #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgromero
force-pushed
the
add-credentials-environment-provider
branch
from
4fd012d to
7295068
Compare
alexgromero
force-pushed
the
add-credentials-environment-provider
branch
from
7295068 to
0816d5d
Compare
alexgromero
commented
Jan 8, 2025
alexgromero
commented
Jan 8, 2025
| @@ -1127,8 +1129,12 @@ def __init__(self, environ=None, mapping=None): | |||
| :param mapping: An optional mapping of variable names to | |||
| environment variable names. Use this if you want to | |||
| change the mapping of access_key->AWS_ACCESS_KEY_ID, etc. | |||
| The dict can have up to 3 keys: ``access_key``, ``secret_key``, | |||
| ``session_token``. | |||
| The dict can have up to 5 keys: | |||
There was a problem hiding this comment.
The current mapping is:
{
'access_key': 'AWS_ACCESS_KEY_ID',
'secret_key': 'AWS_SECRET_ACCESS_KEY',
'token': ['AWS_SECURITY_TOKEN', 'AWS_SESSION_TOKEN'],
'expiry_time': 'AWS_CREDENTIAL_EXPIRATION',
'account_id': 'AWS_ACCOUNT_ID',
}
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## account-id-endpoint-routing #3332 +/- ##
==============================================================
Coverage ? 93.18%
==============================================================
Files ? 66
Lines ? 14430
Branches ? 0
==============================================================
Hits ? 13446
Misses ? 984
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces
account_idto the environment variable credential provider. With this update, users can now provide anAWS_ACCOUNT_IDenvironment variable, which will be associated with the credentials when they are loaded.Testing
Functional testing to ensure the
account_idgets propagated and resolved to the correct endpoint for each credential provider will be added in an upcoming PR.