Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Fixes #904

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Windows Fixes #904

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39e396d
separate out the config and build steps in the Windows CI
varunagrawal Oct 23, 2021
a8f47a7
upgrade Windows boost version and make CI faster
varunagrawal Oct 23, 2021
c9a547f
specify build type at a finer level
varunagrawal Oct 26, 2021
358c3cf
revert boost change and make clang the default compiler
varunagrawal Oct 27, 2021
1cd873f
use msvc compiler but set LTO to OFF
varunagrawal Oct 27, 2021
d5b4104
add GTSAM_EXPORT and GTSAM_UNSTABLE_EXPORT keywords
varunagrawal Oct 28, 2021
fd44a66
simplify the check build
varunagrawal Oct 28, 2021
2b38340
comment out Windows Release CI since it takes too long
varunagrawal Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ jobs:
CTEST_PARALLEL_LEVEL: 2
CMAKE_BUILD_TYPE: ${{ matrix.build_type }}
GTSAM_BUILD_UNSTABLE: ${{ matrix.build_unstable }}
BOOST_VERSION: 1.72.0
BOOST_EXE: boost_1_72_0-msvc-14.2
# We need Boost 1.76 for this reason:
# https://stackoverflow.com/questions/66489199/warnings-in-visual-studio2019-compiling-with-boost-1-75
BOOST_VERSION: 1.76.0
BOOST_EXE: boost_1_76_0-msvc-14.2

strategy:
fail-fast: false
Expand Down Expand Up @@ -90,13 +92,16 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Build
- name: Configuration
run: |
cmake -E remove_directory build
cmake -B build -S . -DGTSAM_BUILD_EXAMPLES_ALWAYS=OFF -DBOOST_ROOT="${env:BOOST_ROOT}" -DBOOST_INCLUDEDIR="${env:BOOST_ROOT}\boost\include" -DBOOST_LIBRARYDIR="${env:BOOST_ROOT}\lib"
cmake --build build --config ${{ matrix.build_type }} --target gtsam
cmake --build build --config ${{ matrix.build_type }} --target gtsam_unstable
cmake --build build --config ${{ matrix.build_type }} --target wrap
cmake --build build --config ${{ matrix.build_type }} --target check.base
cmake --build build --config ${{ matrix.build_type }} --target check.base_unstable
cmake --build build --config ${{ matrix.build_type }} --target check.linear
cmake -B build -S . -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DGTSAM_BUILD_EXAMPLES_ALWAYS=OFF -DBOOST_ROOT="${env:BOOST_ROOT}" -DBOOST_INCLUDEDIR="${env:BOOST_ROOT}\boost\include" -DBOOST_LIBRARYDIR="${env:BOOST_ROOT}\lib"

- name: Build
run: |
cmake --build build -j 4 --target gtsam
cmake --build build -j 4 --target gtsam_unstable
cmake --build build -j 4 --target wrap
cmake --build build -j 4 --target check.base
cmake --build build -j 4 --target check.base_unstable
cmake --build build -j 4 --target check.linear