Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Factors for arbitrary cameras #862

Merged
merged 60 commits into from
Nov 8, 2021
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
be55635
starting to make templates for smart projection factors uniform (all …
Aug 24, 2021
cf3cf39
investigating potential templating alternatives
Aug 25, 2021
db2a915
don't like it - going to create a different class
Aug 25, 2021
8d9ede8
reverted all changes back to master
Aug 26, 2021
432921e
and created a new factor instead - moving to testing now
Aug 26, 2021
37dfb0c
compiles, testing now
Aug 26, 2021
df82ca1
fixed bug
Aug 26, 2021
492c2b8
progress on tests
Aug 26, 2021
7b399a3
removed line
Aug 26, 2021
b523623
still challenging to parse extrinsics
Aug 26, 2021
330a100
Merge branch 'feature/rollingShutterSmartFactors' into feature/camera…
Aug 26, 2021
d004a8c
tests finally passing!
Aug 26, 2021
8af633a
Merge branch 'feature/rollingShutterSmartFactors' into feature/camera…
Aug 26, 2021
fe75554
added capability to use multiple measurements from the same pose. unf…
Aug 26, 2021
050d64b
all tests pass except one on serialization
Aug 26, 2021
9479bdd
passing tough test - nice!
Aug 26, 2021
7d80f52
done with all tests
Aug 26, 2021
e9641ba
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Aug 29, 2021
94727d8
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Aug 29, 2021
0b9c368
Removed types defined in Base class
dellaert Aug 29, 2021
e0946df
Documented linear factors better.
dellaert Aug 29, 2021
4ef234b
Formatting and better documentation
dellaert Aug 29, 2021
372ae27
Added two ReadMe files to document the plethora of smart factors.
dellaert Aug 29, 2021
c0262b0
Address review comments, docs only.
dellaert Aug 29, 2021
f3c65d9
Merge pull request #865 from borglab/feature/readmes
dellaert Aug 29, 2021
c4b6487
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Sep 23, 2021
8c244a2
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Oct 2, 2021
b49bd12
renamed smartProjectionFactorP -> smartProjectionRigFactor
Oct 2, 2021
a5db090
modernized factor
Oct 3, 2021
4c10be9
fixed equal
Oct 3, 2021
117f0d1
fixing tests
Oct 3, 2021
eb82878
halfway there
Oct 3, 2021
fa4de18
working on tests
Oct 3, 2021
3758fda
all tests work except serialization
Oct 3, 2021
4a88574
added extra test with multi cam
Oct 3, 2021
222380c
added more comments here and there
Oct 5, 2021
7988a70
changing API for rolling shutter
Oct 5, 2021
4fd6c2c
bug fix - finalizing last few tests
Oct 6, 2021
0797eae
all tests are passing!
Oct 6, 2021
823a7e7
done with tests
Oct 6, 2021
f0745a9
now I only need to fix comments in rolling shutter factor
Oct 6, 2021
737dcf6
all set here!
Oct 6, 2021
c4cd2b5
fixed formatting (plus small fix: std::vector -> fastVector)
Nov 6, 2021
dfd4a77
formatting + const&
Nov 6, 2021
459c8f9
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Nov 6, 2021
1e38468
more const&
Nov 6, 2021
710a64f
now throwing exception is params are incorrect
Nov 6, 2021
7fa3b5c
added variable in loop
Nov 6, 2021
29f3af5
point2 -> measurement
Nov 6, 2021
dfd86e8
this will need to be applied in #861
Nov 7, 2021
e0af235
disabled timing for test
Nov 7, 2021
5efde52
Merge branch 'develop' into feature/cameraTemplateForAllSmartFactors
Nov 7, 2021
3a4ceda
fixed readme
Nov 7, 2021
2e8d373
serialization is still off
Nov 7, 2021
b1baf6c
final cosmetics
Nov 7, 2021
c105aa4
added intermediate camera variable for clarity
Nov 7, 2021
2c2e43e
got rid of second constructor
Nov 7, 2021
ac58756
further cleanup before moving to sharedPtrs
Nov 7, 2021
4ba9373
moved rig to use shared ptrs
Nov 7, 2021
620f9cb
now using shared ptrs
Nov 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting + const&
lcarlone committed Nov 6, 2021

Unverified

This user has not yet uploaded their public signing key.
commit dfd4a774549923eacd2a380ea0e7fd3b876a65b3
Loading