Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis timeout fixes #429

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Travis timeout fixes #429

merged 1 commit into from
Jul 27, 2020

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jul 24, 2020

Travis has been timing out a lot recently due to the increase in unit tests (especially for DEBUG builds).

This PR increases the number of make cores from 2 to 3.
I also removed the sudo requirement since travis has deprecated that.

@varunagrawal varunagrawal added the bugfix Fixes an issue or bug label Jul 24, 2020
@varunagrawal varunagrawal self-assigned this Jul 24, 2020
@jlblancoc
Copy link
Member

I'm afraid there are only 2 cores in Travis: https://docs.travis-ci.com/user/reference/overview/#virtualization-environments

So the -j3 has no actual effect...

@dellaert
Copy link
Member

Actually that might not be quite true, right? A thread might be blocked on a file resource allowing two other threads to use the cores fully. But proof is in pudding, and @varunagrawal might want to look at the timings in the build to verify...

@dellaert
Copy link
Member

@jlblancoc
Copy link
Member

That's true...

@jlblancoc
Copy link
Member

If you are interested, we could prepare a configuration file for CircleCI instead... from my experience, it's much faster to launch and build... ?

@dellaert
Copy link
Member

If you are interested, we could prepare a configuration file for CircleCI instead... from my experience, it's much faster to launch and build... ?

Let's see how the Github actions work?

@varunagrawal
Copy link
Collaborator Author

If we can move to GitHub Actions this weekend, I am completely fine with closing this PR.

Whatever makes me not have to manually restart CI tasks constantly.

@dellaert
Copy link
Member

Just merge it. I think it might help a bit

@dellaert dellaert merged commit 3a1e74a into develop Jul 27, 2020
@dellaert dellaert deleted the fix/travis-timeout branch July 27, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes an issue or bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants