New-style Errors #1377
Closed
New-style Errors #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchenfc
approved these changes
Jan 10, 2023
Comment on lines
+36
to
+44
| /// Break V into pieces according to its start indices. | ||
| GTSAM_EXPORT Errors createErrors(const VectorValues& V); | ||
|
|
||
| /** Addition */ | ||
| GTSAM_EXPORT Errors operator+(const Errors& b) const; | ||
| /// Print an Errors instance. | ||
| GTSAM_EXPORT void print(const Errors& e, const std::string& s = "Errors"); | ||
|
|
||
| /** subtraction */ | ||
| GTSAM_EXPORT Errors operator-(const Errors& b) const; | ||
| // Check equality for unit testing. | ||
| GTSAM_EXPORT bool equality(const Errors& actual, const Errors& expected, | ||
| double tol = 1e-9); |
There was a problem hiding this comment.
These three functions break backward compatibility for people not using traits, though I'm sure you were already aware.
|
CI failures appear to just be wrapper API change: Lines 632 to 637 in 16136ea unclear how to best handle this. (Linux CI failure appears to just be github hiccup) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get past the Windows compilation problems on #1375, and, because "friends don't let friends inherit from STL containers", here is an attempt to define
Errorsas a typedef toFastList<Vector>.This might still run into the same problem of needing a compare operator for
mergeon Windows, we'll see in CI...Thanks @gchenfc for your help in identifying the issue.