Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid Serialization #1368

Merged
merged 9 commits into from
Jan 4, 2023
Merged

Hybrid Serialization #1368

merged 9 commits into from
Jan 4, 2023

Conversation

varunagrawal
Copy link
Collaborator

Fixed serialization for both discrete and hybrid.
Fixes #1366

@varunagrawal varunagrawal requested a review from dellaert January 3, 2023 23:44
@varunagrawal varunagrawal self-assigned this Jan 3, 2023
dellaert
dellaert approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! But CI fails?

@varunagrawal
Copy link
Collaborator Author

Ah the serialization key export is clashing when tests are grouped. I'll figure this out!

@varunagrawal
Copy link
Collaborator Author

Easy fix is to move to a common testSerializationDiscrete.cpp file. I prefer this since it is cleaner and keeps all the serialization logic together.

Base automatically changed from hybrid/test_with_evaluate to hybrid/elimination January 4, 2023 06:37
@varunagrawal varunagrawal linked an issue Jan 4, 2023 that may be closed by this pull request
Discrete Serialization Support #1366
Closed
@varunagrawal varunagrawal merged commit b62f397 into hybrid/elimination Jan 4, 2023
@varunagrawal varunagrawal deleted the hybrid/serialization branch January 4, 2023 08:51
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
Hybrid Inference
Development

Successfully merging this pull request may close these issues.

Discrete Serialization Support
2 participants
@varunagrawal @dellaert