Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for matlab wrapper in sfm.i #1316

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Fix for matlab wrapper in sfm.i #1316

merged 3 commits into from
Oct 26, 2022

Conversation

akshay-krishnan
Copy link
Contributor

Changes from pair<size_t, size_t> to IndexPair

@akshay-krishnan
Copy link
Contributor Author

@varunagrawal would this fix the matlab wrapper? I don't have matlab myself, so wont be able to test it.

@johnwlambert
Copy link
Contributor

Thanks Akshay. Looks fine to me, but I'll defer to the CI and to anyone with a MATLAB license...

I don't understand why this change is necessary, though : - ) IndexPair should compile to a pair of size_t's, looking at its definition:

class IndexPair : public std::pair<size_t,size_t> {

@varunagrawal
Copy link
Collaborator

@akshay-krishnan compiles great.

@johnwlambert this seems to be something going on at the compiler level and my guess is it has to do with template matching at compile time. You're specifying the template as IndexPair but using std::pair<size_t, size_t> so perhaps the match is incorrect?

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've also added an assertion which was missing.

@akshay-krishnan
Copy link
Contributor Author

Thanks! We can merge once CI completes.

@varunagrawal varunagrawal merged commit 8b2639a into develop Oct 26, 2022
@varunagrawal varunagrawal deleted the fix/track-wrapper branch October 26, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants