Hybrid Pruning #1309
Merged
Hybrid Pruning #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dellaert FYI this PR gets the 1D robot example working extremely well! |
ProfFan
reviewed
Nov 2, 2022
| gtsam::HybridBayesNet newConditionals; | ||
|
|
||
| // NOTE(Varun) Using a for-range loop doesn't work since some of the | ||
| // conditionals are invalid pointers |
There was a problem hiding this comment.
Interesting, I don't think this is possible in a Hybrid Bayes Net?
There was a problem hiding this comment.
It is! I was able to get a simple example up and running with this.
There was a problem hiding this comment.
I have no other explanation why a for-range loop doesn't work, unfortunately...
ProfFan
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got hybrid pruning to work and this PR is the result of it!