Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python-install #1145

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Fix python-install #1145

merged 1 commit into from
Mar 25, 2022

Conversation

varunagrawal
Copy link
Collaborator

Added a quick fix to the CMake for python-install so it no longer needs to install to access protected directories. Also modernized it to use pip install rather than the now deprecated python setup.py install.

@varunagrawal varunagrawal added the python Related to python wrapper label Mar 24, 2022
@varunagrawal varunagrawal requested a review from ProfFan March 24, 2022 20:38
@varunagrawal varunagrawal self-assigned this Mar 24, 2022
@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Mar 24, 2022
@varunagrawal varunagrawal linked an issue Mar 24, 2022 that may be closed by this pull request
Problem with python wrapper build #1081
Closed
Base automatically changed from decision-tree-improvements to develop March 24, 2022 22:33
ProfFan
ProfFan approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Varun!

@varunagrawal varunagrawal merged commit c3788fe into develop Mar 25, 2022
@varunagrawal varunagrawal deleted the fix/python-install branch March 25, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees

@varunagrawal varunagrawal

Labels
python Related to python wrapper quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with python wrapper build
2 participants
@varunagrawal @ProfFan