-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing header for timing target #1112
Conversation
Tagging @ayushbaid as reviewer so he knows timing code exists in GTSAM :-) |
@varunagrawal added you on review as well because I also removed a forgotten obsolete header that prevents double expresso from working for me. It was not needed anymore as you recall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -21,8 +21,6 @@ | |||
#include <gtsam/base/Manifold.h> | |||
#include <gtsam/basis/Basis.h> | |||
|
|||
#include <unsupported/Eigen/KroneckerProduct> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops sorry about that. But great catch!
Failure is because of Azure crapping out. Just need to re-run it again. |
OK, thanks. I'll restart that CI run. |
Although, that would restart a bunch. I'll just ignore that failure if all others pass. |
I did not get this. Does including the header file means we will automatically start timing all the functions in that file? |
No, absolutely not. There are a number of timing scripts in GTSAM, but you have to enable timing with the mechanisms described in the header. |
that's it :-)