Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up loading SfmData #1082

Merged
merged 9 commits into from
Feb 2, 2022
Merged

Cleaned up loading SfmData #1082

merged 9 commits into from
Feb 2, 2022

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Feb 1, 2022

  • made static constructors
  • deprecated functions using a non-const reference
  • added an example in Python with Balbianello:
    image

@dellaert dellaert self-assigned this Feb 1, 2022
@dellaert dellaert added high-priority Need this done quickly quick-review Quick and easy PR to review labels Feb 1, 2022
akshay-krishnan
akshay-krishnan approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@akshay-krishnan akshay-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the new static read methods, avoids quite some boilerplate.

gtsam/sfm/SfmData.cpp Show resolved Hide resolved
gtsam/sfm/SfmData.cpp Show resolved Hide resolved
gtsam/sfm/SfmData.cpp Show resolved Hide resolved
gtsam/sfm/SfmData.h Show resolved Hide resolved
@dellaert
Copy link
Member Author

dellaert commented Feb 1, 2022

Thanks! The exception does not need to be flagged, it's just a deprecated method and making sure it returns a bool - that's a pretty useless behavior, that's also why deprecated.

johnwlambert
johnwlambert approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though a few minor python syntax changes could be made

@dellaert
Copy link
Member Author

dellaert commented Feb 1, 2022

Okidoke!

@dellaert
Copy link
Member Author

dellaert commented Feb 1, 2022

PS I know why the CI fails, will fix that as well.

@dellaert dellaert merged commit fb1e3c3 into develop Feb 2, 2022
@dellaert dellaert deleted the fix/sfm_reading branch February 2, 2022 17:18
@akshay-krishnan akshay-krishnan mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-krishnan akshay-krishnan akshay-krishnan approved these changes

@johnwlambert johnwlambert johnwlambert approved these changes

Assignees

@dellaert dellaert

Labels
high-priority Need this done quickly quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dellaert @johnwlambert @akshay-krishnan