Added inference module #1068
Merged
Added inference module #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
added
quick-review
|
Thanks for the quick review, @ProfFan ! |
|
I don't understand how this changes anything. It's not like we do That being said, I am disliking the multiple #include pybind/stl.h. There should just be one and I'll do that next week since this has been on the wrapper agenda long enough :/ |
|
Is VariableIndex the big update? Cool! |
| class VariableIndex { | ||
| // Standard Constructors and Named Constructors | ||
| VariableIndex(); | ||
| // TODO: Templetize constructor when wrap supports it |
There was a problem hiding this comment.
FYI wrapper supports constructor templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fact that the inference module was forgotten when we split up the wrapper :-)