Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some discrete improvements #1045

Merged
merged 8 commits into from
Jan 20, 2022
Merged

Some discrete improvements #1045

merged 8 commits into from
Jan 20, 2022

Conversation

dellaert
Copy link
Member

Some more changes needed for the book:

  • New, more powerful choose, yields a Conditional now
  • Wrap push_back methods for DiscreteFactorGraph, and also did some reformatting/docs/using
  • Change factor graph plotting default to not confuse people

@dellaert dellaert requested a review from varunagrawal January 19, 2022 03:22
@dellaert dellaert requested a review from ProfFan January 19, 2022 20:32
@dellaert dellaert merged commit d8abdc2 into develop Jan 20, 2022
@dellaert dellaert deleted the feature/discrete_wrapping branch January 20, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@varunagrawal varunagrawal Awaiting requested review from varunagrawal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @ProfFan