Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscreteBayesNet sample/optimize variants #1043

Merged
merged 1 commit into from
Jan 18, 2022
Merged

DiscreteBayesNet sample/optimize variants #1043

merged 1 commit into from
Jan 18, 2022

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 18, 2022 •
edited
Loading

Two more sample/optimize variants in DiscreteBayesNet, that allow us to sample "incomplete" Bayes nets, e.g., resulting from incomplete elimination. Two things to note:

  • test is in Python.
  • given argument is passed by value, no accident.
  • added better docs as well
  • I reformatted .cpp file, might want to hide whitespace changes

@dellaert dellaert requested a review from xsj01 January 18, 2022 04:02
xsj01
xsj01 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@xsj01 xsj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dellaert dellaert merged commit 296b469 into develop Jan 18, 2022
@dellaert dellaert deleted the feature/more_discrete_methods branch January 18, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsj01 xsj01 xsj01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @xsj01