Subgraph API change #1010
Merged
Subgraph API change #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some love? |
varunagrawal
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Looks good to me modulo 2 comments. Would like to hear @jlblancoc's thoughts as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR from some refactoring I did over the break, to get rid of shared pointers for containers. It is totally appropriate that we use shared pointers for factors (although, maybe we should not!), but it never made sense (I see now) that we used shared pointers for graphs, as they are not really shuffled around like factors.
The big changes that are coming (branches have not been published yet) are mostly in linear, to get a newer and faster API for elimination -- prompted by development in hybrid branch. This PR removes shared pointers from the subgraph API, for starters.
Adding @jlblancoc as a reviewer, partly to get his opinion on above, and @ProfFan as FYI as I know he has a forked branch with lots of shared pointer changes (presumably moving to std::shared_ptr).