Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to LocalPlaneFactor #1003

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Minor changes to LocalPlaneFactor #1003

merged 2 commits into from
Jan 3, 2022

Conversation

dwisth
Copy link
Contributor

@dwisth dwisth commented Jan 3, 2022

Two small changes:

  • Fix destructor virtual keyword.
  • Change from SharedGaussian to SharedNoiseModel to support robust cost functions.

@dwisth dwisth requested a review from varunagrawal January 3, 2022 05:11
varunagrawal
varunagrawal approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @dwisth

@varunagrawal varunagrawal merged commit a119eb8 into develop Jan 3, 2022
@varunagrawal varunagrawal deleted the fix/change-local-plane-factor-to-shared-noise-model branch January 3, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwisth @varunagrawal