Fix segfault when showZero==false

borglab · Jan 4, 2022 · 541127f · 541127f
1 parent dcc74d8
commit 541127f
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/gtsam/discrete/DecisionTree-inl.h b/gtsam/discrete/DecisionTree-inl.h
@@ -261,9 +261,8 @@ namespace gtsam {
 
         // Check if zero
         if (!showZero) {
-          const Leaf* leaf = dynamic_cast<const Leaf*> (branch.get());
-          std::string value = valueFormatter(leaf->constant());
-          if (leaf && value.compare("0")) continue;
+          const Leaf* leaf = dynamic_cast<const Leaf*>(branch.get());
+          if (leaf && valueFormatter(leaf->constant()).compare("0")) continue;
         }
 
         os << "\"" << this->id() << "\" -> \"" << branch->id() << "\"";