Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear contents of log_text after successfull backup #1626

Merged
merged 11 commits into from
May 18, 2023

Conversation

aadityasinha-dotcom
Copy link
Contributor

fixes #1389

@diivi
Copy link
Contributor

diivi commented Mar 5, 2023

Just wanted to add here that personally, I'd like to see the backup finished message (as a success feedback) and then maybe click on a "Done" or "Clear" button to clear this text. This is also why I opened #1618.
With the current approach, the user can easily miss the "backup finished" text.

@DaffyTheDuck
Copy link

Just wanted to add here that personally, I'd like to see the backup finished message (as a success feedback) and then maybe click on a "Done" or "Clear" button to clear this text. This is also why I opened #1618. With the current approach, the user can easily miss the "backup finished" text.

Or I guess the other approach could be like adding some time constraint, after that the message will automatically disappear if the backup is successful, if there's failure then we could add a clear button to clear the log as you mentioned in #1618 because having a time constraint there will be a problem

@aadityasinha-dotcom
Copy link
Contributor Author

Yep we can add time constraint

@aadityasinha-dotcom
Copy link
Contributor Author

For me clear button can be a little hassle, we can add the clear button when we get some failure other wise it will show successful message for few seconds 😊

@real-yfprojects
Copy link
Collaborator

With the current approach, the user can easily miss the "backup finished" text.

Are you talking about this PR or the current master branch?
I am not in favour of the timed approach because I could easily miss a message when I am away from the computer. My intention of #1389 was only clearing the log for progress/status updates that aren't relevant after the borg job has finished. This would include showing the added files when creating a backup which looks like this:

/home/user/Documents/new.txt (A)

aadityasinha-dotcom and others added 2 commits March 7, 2023 10:25
Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
@real-yfprojects real-yfprojects changed the title Clear contents of log_text after succefull backup Clear contents of log_text after successfull backup Mar 8, 2023
real-yfprojects
real-yfprojects previously approved these changes Mar 8, 2023
@real-yfprojects real-yfprojects requested a review from m3nu March 8, 2023 16:25
real-yfprojects
real-yfprojects previously approved these changes Apr 3, 2023
m3nu
m3nu previously approved these changes Apr 13, 2023
@m3nu m3nu self-assigned this Apr 13, 2023
@real-yfprojects real-yfprojects dismissed stale reviews from m3nu and themself via 0031859 May 18, 2023 19:23
@real-yfprojects real-yfprojects merged commit d7634e8 into borgbase:master May 18, 2023
DaffyTheDuck pushed a commit to DaffyTheDuck/vorta that referenced this pull request Jun 14, 2023
Currently the label `logText` is not cleared after a borg command finished. When creating a backup the label will show the path of the last backuped file even after backup completion.

This changes that and clears `logText` after the backup.

* src/vorta/borg/create.py (BorgCreateJob.process_result)

---------

Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear contents of logText after successfull backup.
5 participants