Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear contents of logText after successfull backup. #1389

Closed
real-yfprojects opened this issue Aug 14, 2022 · 20 comments · Fixed by #1626
Closed

Clear contents of logText after successfull backup. #1389

real-yfprojects opened this issue Aug 14, 2022 · 20 comments · Fixed by #1626
Assignees
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function

Comments

@real-yfprojects
Copy link
Collaborator

Currently the label logText is not cleared after a borg command finished. When creating a backup the label will show the path of the last backuped file even after backup completion.

Instead the progressText and logText labels should be cleared if they show information only relevant during the command execution.

@real-yfprojects real-yfprojects added the type:enhancement Improvement of an existing function label Aug 14, 2022
@real-yfprojects
Copy link
Collaborator Author

This was already reported here: #1356 (comment)

@real-yfprojects real-yfprojects added good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it labels Aug 14, 2022
@m3nu m3nu added this to the v0.8.x (Next minor release) milestone Nov 29, 2022
@aadityasinha-dotcom
Copy link
Contributor

Hey @real-yfprojects can I work on this issue?

@real-yfprojects
Copy link
Collaborator Author

Sure, you'll need to be familiar with (py)qt signals for this one.

@aadityasinha-dotcom
Copy link
Contributor

Hey, @real-yfprojects can you explain me about this issue?

@real-yfprojects
Copy link
Collaborator Author

Hey, @real-yfprojects can you explain me about this issue?

What is your question?

@DaffyTheDuck
Copy link

DaffyTheDuck commented Mar 3, 2023

Hey! @aadityasinha-dotcom are you still working on this ? otherwise I would like to work on this

@aadityasinha-dotcom
Copy link
Contributor

Yes

@DaffyTheDuck
Copy link

Hey, @real-yfprojects can you explain me about this issue?

I guess @real-yfprojects means something like this

log_text

See the bottom text disappears after the job is finished 😄

@real-yfprojects
Copy link
Collaborator Author

See the bottom text disappears after the job is finished

That is the goal. Vorta doesn't do this yet afaik.

@aadityasinha-dotcom
Copy link
Contributor

okay got it, thank you @DaffyTheDuck

@aadityasinha-dotcom
Copy link
Contributor

2023-03-03.18-26-20.mp4

But in my system it does not disappears

@DaffyTheDuck
Copy link

But in my system it does not disappears

That's what you have to figure out 😄

@aadityasinha-dotcom
Copy link
Contributor

aadityasinha-dotcom commented Mar 5, 2023

@real-yfprojects can you explain this?

@real-yfprojects
Copy link
Collaborator Author

can you explain this?

this is an ambiguous pronoun. Be more specific with your question. State what you have already figured out. What problems you are facing and what kind of advice you are expecting.

If I tell you in detail what lines of code have to be written. I can just write the code instead.

@DaffyTheDuck
Copy link

@real-yfprojects can you explain this?

In simple, he means that you've to modify the code in such a way that it should remove the labels after the backup is complete 😄 (you can also tweak the code in a way that as shown in my gif it wont remove it instantly)

@aadityasinha-dotcom
Copy link
Contributor

okay

@aadityasinha-dotcom
Copy link
Contributor

aadityasinha-dotcom commented Mar 5, 2023

But my question is, why it is not disappearing in my system? @DaffyTheDuck

@DaffyTheDuck
Copy link

DaffyTheDuck commented Mar 5, 2023

But my question is, why it is not disappearing in my system? @DaffyTheDuck

Because I've modified the code in my system which doesn't exists in main repository, your system contains the code from main repository, so to close this issue you've to modify the code in your system and push the changes so @real-yfprojects and @m3nu can review it 😄

@aadityasinha-dotcom
Copy link
Contributor

My bad, sorry I got confused what was the goal of this issue. I thought we need not to disappear the text sorry. And thank you for the clarification @DaffyTheDuck

@DaffyTheDuck
Copy link

My bad, sorry I got confused what was the goal of this issue. I thought we need not to disappear the text sorry. And thank you for the clarification @DaffyTheDuck

Never Mind 😄 and All The Best 👍🏼

@real-yfprojects real-yfprojects changed the title Clear contents of logText after successful backup. Clear contents of logText after successfull backup. Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple change to start learning code base help wanted This issue is available, comment if you want to fix it type:enhancement Improvement of an existing function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants