Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--keep-tag-files for borg list? #3226

Closed
ThomasWaldmann opened this issue Oct 28, 2017 · 7 comments
Closed

--keep-tag-files for borg list? #3226

ThomasWaldmann opened this issue Oct 28, 2017 · 7 comments
Assignees
Labels

Comments

@ThomasWaldmann
Copy link
Member

From SanskritFritz (IRC):

in the docs there is --keep-tag-files for borg list.
A result of copy-paste or is there a point?

same with borg diff.

Note: maybe a global option? check whether it is better to make it a local option. check which branches are affected.

@ThomasWaldmann ThomasWaldmann self-assigned this Nov 4, 2017
ThomasWaldmann added a commit that referenced this issue Nov 4, 2017
borg list: remove tag-file options, fixes #3226
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Nov 4, 2017
they are not used for borg list.

(cherry picked from commit 702afa9)
@SanskritFritz
Copy link
Contributor

How about borg diff? Is the option used there?

@ThomasWaldmann
Copy link
Member Author

ah, forgot that. fixing...

@ThomasWaldmann ThomasWaldmann reopened this Nov 4, 2017
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Nov 4, 2017
they are not used for borg diff.

(cherry picked from commit 67f6aaa)
@SanskritFritz
Copy link
Contributor

How is the documentation fixed then? Is it generated or do you have to fix it manually? (I can make a PR if it involves only manual text editing).

@ThomasWaldmann
Copy link
Member Author

the docs and man pages are created from the code, no manual work needed.

ThomasWaldmann added a commit that referenced this issue Nov 4, 2017
borg list: remove tag-file options, fixes #3226
@SanskritFritz
Copy link
Contributor

SanskritFritz commented Nov 4, 2017

OK, thanks. Also I have my doubts about --exclude-if-present and --exclude-caches as well. What do you think?

@ThomasWaldmann
Copy link
Member Author

the changes remove these from diff and list:

$ borg list --help
...
  --exclude-caches      exclude directories that contain a CACHEDIR.TAG file
                        (http://www.brynosaurus.com/cachedir/spec.html)
  --exclude-if-present NAME
                        exclude directories that are tagged by containing a
                        filesystem object with the given NAME
  --keep-exclude-tags, --keep-tag-files
                        if tag objects are specified with ``--exclude-if-
                        present``, don't omit the tag objects themselves from
                        the backup archive

@SanskritFritz
Copy link
Contributor

Ah sorry for the noise. I'll update the shell completions accordingly.

ThomasWaldmann added a commit that referenced this issue Nov 4, 2017
borg diff: remove tag-file options, fixes #3226
ThomasWaldmann added a commit that referenced this issue Nov 4, 2017
borg diff: remove tag-file options, fixes #3226
ThomasWaldmann added a commit that referenced this issue Nov 4, 2017
@ghost ghost mentioned this issue Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants