Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: make the estimate-bracken action unavailable on OSX #232

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jan 16, 2025

This PR removes the estimate-bracken action registration from plugin_setup.py in case the detected OS is OSX. The reason for this behaviour is the unavailability of Bracken on OSX platform - we don't want the users to run into weird erros.

More details in this forum post.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (b6d068a) to head (87bfc75).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   95.60%   95.50%   -0.10%     
==========================================
  Files          34       34              
  Lines        1956     1980      +24     
  Branches      226      231       +5     
==========================================
+ Hits         1870     1891      +21     
- Misses         48       49       +1     
- Partials       38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misialq misialq requested review from nbokulich and Copilot January 16, 2025 11:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • setup.cfg: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant