Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 2.0.0] Support for celluloid 0.18 #1

Merged
merged 3 commits into from
Apr 18, 2021

Conversation

bogdanRada
Copy link
Owner

@bogdanRada bogdanRada commented Mar 26, 2021

Summary

  • Added support for celluloid 0.18

Changelog

  • The server and the client supporto also a log_level option to set the logging level
  • When a client publishes to a channel where there are no subscribers the server will save those messages in the registry and will send them as soon as a client registers to that channel, afterwards those messages are deleted.
  • Currently those messages are saved in memory.

Known Issues:

  • Does not work on Ruby 3.0.0 due to some errors with celluloid/io . Need to investigate that further

@bogdanRada bogdanRada self-assigned this Mar 26, 2021
Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
examples/simple_test.rb Outdated Show resolved Hide resolved
examples/simple_test.rb Outdated Show resolved Hide resolved
examples/simple_test.rb Outdated Show resolved Hide resolved
lib/celluloid_pubsub/base_actor.rb Show resolved Hide resolved
lib/celluloid_pubsub/base_actor.rb Show resolved Hide resolved
lib/celluloid_pubsub/base_actor.rb Outdated Show resolved Hide resolved
lib/celluloid_pubsub/base_actor.rb Show resolved Hide resolved
lib/celluloid_pubsub/base_actor.rb Show resolved Hide resolved
@bogdanRada bogdanRada requested a review from houndci-bot March 26, 2021 18:49
@bogdanRada bogdanRada force-pushed the brada/compatibility-with-latest-celluloid branch from 74da290 to b45274b Compare March 26, 2021 21:25
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Style/StringChars found in .rubocop.yml, unrecognized...
Error: unrecognized cop Style/StringChars found in .rubocop.yml, unrecognized cop Gemspec/DateAssignment found in .rubocop.yml, unrecognized cop Layout/SpaceBeforeBrackets found in .rubocop.yml, unrecognized cop Lint/AmbiguousAssignment found in .rubocop.yml, unrecognized cop Lint/DeprecatedConstants found in .rubocop.yml, unrecognized cop Lint/LambdaWithoutLiteralBlock found in .rubocop.yml, unrecognized cop Lint/NumberedParameterAssignment found in .rubocop.yml, unrecognized cop Lint/OrAssignmentToConstant found in .rubocop.yml, unrecognized cop Lint/RedundantDirGlobSort found in .rubocop.yml, unrecognized cop Lint/SymbolConversion found in .rubocop.yml, unrecognized cop Lint/TripleQuotes found in .rubocop.yml, unrecognized cop Style/EndlessMethod found in .rubocop.yml, unrecognized cop Style/HashConversion found in .rubocop.yml, unrecognized cop Style/HashExcept found in .rubocop.yml, unrecognized cop Style/IfWithBooleanLiteralBranches found in .rubocop.yml

@bogdanRada bogdanRada force-pushed the brada/compatibility-with-latest-celluloid branch 2 times, most recently from 93f67ba to 2bda31d Compare March 26, 2021 22:13
@coveralls
Copy link

coveralls commented Mar 27, 2021

Coverage Status

Coverage increased (+22.8%) to 97.033% when pulling b7491ad on brada/compatibility-with-latest-celluloid into e555825 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 78.223% when pulling bdb8b96 on brada/compatibility-with-latest-celluloid into e555825 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 78.223% when pulling bdb8b96 on brada/compatibility-with-latest-celluloid into e555825 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 78.223% when pulling bdb8b96 on brada/compatibility-with-latest-celluloid into e555825 on master.

Repository owner deleted a comment from houndci-bot Mar 28, 2021
@bogdanRada bogdanRada force-pushed the brada/compatibility-with-latest-celluloid branch from 660808c to 8afad8f Compare March 30, 2021 20:52
@bogdanRada bogdanRada merged commit 0038ce9 into master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants