Merge pull request #1 from bogdanRada/brada/compatibility-with-latest…

…-celluloid

[Release 2.0.0]  Support for celluloid 0.18

.hound.yml

@@ -0,0 +1,10 @@
+rubocop:
+  config_file: .rubocop.yml
+  enabled: false
+
+flog:
+  enabled: false
+
+reek:
+  enabled: false
+

.rubocop.yml

@@ -1,77 +1,159 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
+  TargetRubyVersion: 3.0
+  DisplayStyleGuide: true
+  ExtraDetails: true
   Exclude:
     - celluloid_pubsub.gemspec
+    - gemfiles/**/**
     - bin/**/*
     - Guardfile
     - vendor/**/**
     - examples/**/**
     - spec/**/*
     - Gemfile
     - Rakefile
+    - Appraisals
+
+Style/OptionalBooleanParameter:
+  Enabled: false
 
-  TargetRubyVersion: 2.3
-
-ClassLength:
-  Max: 500
+Lint/RedundantRequireStatement:
+  Enabled: false
 
-Documentation:
+Style/StringChars: # (new in 1.12)
   Enabled: true
 
-Encoding:
+Metrics/ClassLength:
+  Max: 900
+
+Metrics/ModuleLength:
+  Max: 900
+
+Style/Documentation:
   Enabled: false
 
-LineLength:
+Style/Encoding:
+  Enabled: false
+
+Layout/LineLength:
   Max: 200
 
-AccessModifierIndentation:
-  EnforcedStyle: outdent
+Layout/AccessModifierIndentation:
+  EnforcedStyle: indent
 
-IfUnlessModifier:
+Style/IfUnlessModifier:
   Enabled: false
 
-CaseIndentation:
-  IndentWhenRelativeTo: case
-  IndentOneStep: true
+Layout/CaseIndentation:
+  EnforcedStyle: case
+  IndentOneStep: false
 
-MethodLength:
+Metrics/MethodLength:
   CountComments: false
   Max: 20
 
-SignalException:
+Style/SignalException:
   Enabled: false
 
-ColonMethodCall:
+Style/ColonMethodCall:
   Enabled: false
 
-AsciiComments:
+Style/AsciiComments:
   Enabled: false
 
-RegexpLiteral:
+Style/RegexpLiteral:
   Enabled: false
 
-AssignmentInCondition:
+Lint/AssignmentInCondition:
   Enabled: false
 
-ParameterLists:
+Metrics/ParameterLists:
   CountKeywordArgs: false
 
-SingleLineBlockParams:
+Style/SingleLineBlockParams:
   Methods:
     - reduce:
-      - memo
-      - item
+        - memo
+        - item
 
 Metrics/AbcSize:
   Enabled: false
 
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+
+Style/GlobalStdStream:
+  Enabled: false
+
 Style/CollectionMethods:
   Enabled: true
 
 Style/SymbolArray:
   Enabled: true
 
-Style/ExtraSpacing:
+Layout/ExtraSpacing:
   Enabled: true
 
-Style/FileName:
+Naming/FileName:
   Enabled: false
+
+Gemspec/DateAssignment: # (new in 1.10)
+  Enabled: true
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: true
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashConversion: # (new in 1.10)
+  Enabled: true
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: true
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: true

.rubocop_todo.yml

@@ -0,0 +1,7 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2021-03-26 21:52:12 UTC using RuboCop version 1.12.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.

.travis.yml

@@ -1,30 +1,67 @@
 language: ruby
-sudo: false
 
 cache: bundler
 
 bundler_args: --no-deployment --binstubs=./bin
 
 before_install:
   - "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
-  - gem install bundler
-  - gem update bundler
+  - if [[ ! "${RUBY_VERSION}" =~ "jruby" ]]; then travis_wait 30 rvm rubygems current; fi
+  - if [[ ! "${RUBY_VERSION}" =~ "jruby" ]]; then yes | gem update --system --force || true; fi
+  - gem --version
+  - gem install bundler -v 1.17.3
+  - export MY_BUNDLER_VERSION='_1.17.3_'
+  - bundle ${MY_BUNDLER_VERSION} --version
 
 install:
-  - bundle install --path vendor/bundle
+  - bundle ${MY_BUNDLER_VERSION} config --local path vendor/bundle
+  - bundle ${MY_BUNDLER_VERSION} config --local jobs 3
+  - bundle ${MY_BUNDLER_VERSION} config --local retry 3
+  - bundle ${MY_BUNDLER_VERSION} config --local binstubs ./bin
+  - bundle ${MY_BUNDLER_VERSION} config --local bin ./bin
+  - bundle ${MY_BUNDLER_VERSION} install
+  - gem env
+  - bundle ${MY_BUNDLER_VERSION} env
 
 script:
-   - echo $BUNDLE_GEMFILE
-   - bundle exec rake
+  - echo $BUNDLE_GEMFILE
+  - bundle ${MY_BUNDLER_VERSION} exec rake
 
+gemfile:
+  - gemfiles/cell_0.16.0.gemfile
+  - gemfiles/cell_0.17.3.gemfile
+  - gemfiles/cell_0.17.4.gemfile
+  - gemfiles/cell_0.18.0.gemfile
+matrix:
+  fast_finish: true
+  allow_failures:
+    - rvm: 2.2.5
+  exclude:
+    - rvm: 2.0.0
+      gemfile: gemfiles/cell_0.18.0.gemfile
+    - rvm: 2.1.3
+      gemfile: gemfiles/cell_0.18.0.gemfile
+    - rvm: 2.2.0
+      gemfile: gemfiles/cell_0.18.0.gemfile
+    - rvm: 2.2.2
+      gemfile: gemfiles/cell_0.18.0.gemfile
+    - rvm: 2.2.5
+      gemfile: gemfiles/cell_0.18.0.gemfile
 rvm:
-- 2.2.2
-- 2.2.5
-- 2.3.1
-- 2.3.2
-- 2.3.3
-- 2.4.0
+  - 2.1.3
+  - 2.2.2
+  - 2.2.5
+  - 2.3.1
+  - 2.3.2
+  - 2.3.3
+  - 2.4.0
+  - 2.5.3
+  - 2.6.5
+  - 2.7.1
+ # - 3.0.0 - celluloid/io doesn't work
+
 env:
- - RAILS_ENV=test RACK_ENV=test
+  - RAILS_ENV=test RACK_ENV=test APP_ENV=test
+
 notifications:
   email: false

Appraisals

@@ -1,11 +1,15 @@
-appraise "celluloid-0.16.0" do
+appraise "cell-0.16.0" do
   gem "celluloid", "0.16.0"
 end
 
-appraise "celluloid-0.17.3" do
+appraise "cell-0.17.3" do
   gem "celluloid", "0.17.3"
 end
 
-appraise "celluloid-0.18.0.pre" do
-  gem "celluloid", "0.18.0.pre"
+appraise "cell-0.17.4" do
+  gem "celluloid", "0.17.4"
 end
+
+appraise "cell-0.18.0" do
+  gem "celluloid", "0.18.0"
+end

Gemfile

@@ -1,3 +1,3 @@
 source 'http://rubygems.org'
 
-gemspec
+gemspec

Rakefile

@@ -20,8 +20,8 @@ task :all do |_t|
     # require 'json'
     # puts JSON.pretty_generate(ENV.to_hash)
     if ENV['BUNDLE_GEMFILE'] =~ /gemfiles/
-      appraisal_name = ENV['BUNDLE_GEMFILE'].scan(/rails\_(.*)\.gemfile/).flatten.first
-      command_prefix = "appraisal rails-#{appraisal_name}"
+      appraisal_name = ENV['BUNDLE_GEMFILE'].scan(/cell\_(.*)\.gemfile/).flatten.first
+      command_prefix = "appraisal cell-#{appraisal_name}"
       exec ("#{command_prefix} bundle install && #{command_prefix} bundle exec rspec && bundle exec rake coveralls:push ")
     else
       exec(' bundle exec appraisal install && bundle exec rake appraisal spec && bundle exec rake coveralls:push')

celluloid_pubsub.gemspec

@@ -19,20 +19,21 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_runtime_dependency 'celluloid', '>= 0.16', '>= 0.16.0'
+  s.add_runtime_dependency 'celluloid-fsm'
   s.add_runtime_dependency 'celluloid-io', '>= 0.16', '>= 0.16.2'
-  s.add_runtime_dependency 'reel', '~> 0.6', '>= 0.6.0'
+  #TODO: reel 0.6.1 seems broken - Need to investigate
+  s.add_runtime_dependency 'reel', '0.6.0'
   s.add_runtime_dependency 'celluloid-websocket-client', '~> 0.0', '>= 0.0.1'
-  s.add_runtime_dependency 'celluloid-pmap', '~> 0.2', '>= 0.2.2'
+  s.add_runtime_dependency 'celluloid-pmap', '~> 1.0'
   s.add_runtime_dependency 'activesupport', '>= 4.0', '>= 4.0'
 
   s.add_development_dependency 'appraisal', '~> 2.1', '>= 2.1'
   s.add_development_dependency 'rspec', '~> 3.5', '>= 3.5'
   s.add_development_dependency 'simplecov', '~> 0.12', '>= 0.12'
   s.add_development_dependency 'simplecov-summary', '~> 0.0', '>= 0.0.5'
-  s.add_development_dependency 'mocha', '~> 1.2', '>= 1.2'
   s.add_development_dependency 'coveralls', '~> 0.8', '>= 0.8'
   s.add_development_dependency 'rake', '>= 12.0', '>= 12.0'
-  s.add_development_dependency 'yard', '~> 0.8', '>= 0.8.7'
+  s.add_development_dependency 'yard', '>= 0.9.20'
   s.add_development_dependency 'redcarpet', '~> 3.4', '>= 3.4'
   s.add_development_dependency 'github-markup', '~> 1.4', '>= 1.4'
   s.add_development_dependency 'inch', '~> 0.7', '>= 0.7'