Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Documentation for FetchContent Changes #224

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

FlorianXXIV
Copy link
Contributor

After creating targets for CMakes FetchContent in #217 I updated the documentation so that the shown target is correct.
So
from target_link_libraries(${PROJECT_NAME} PRIVATE Graaf_lib)
to target_link_libraries(${PROJECT_NAME} PRIVATE Graaf::Graaf)

I also added a section about the CMake Options that are available, and gave examples on how to use them when people include this library for their Project.

I verified the documentation building locally.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (7bebd60) to head (6a8d969).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          56       56           
  Lines        2586     2586           
  Branches      135      135           
=======================================
  Hits         2575     2575           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving the documentation here!
LGTM

@bobluppes bobluppes merged commit 3aace11 into bobluppes:main Jun 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants