CMake Targets for FetchContent #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m> wasn't included. I added the include to make the project build.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I forgot to add a lable when creating the request and now It seems I can't do that afterwards. Sorry about that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 56 56
Lines 2586 2586
Branches 135 135
=======================================
Hits 2575 2575
Misses 11 11 ☔ View full report in Codecov by Sentry. |
Merged
Update to newest version of graaf
…algorithm> wasn't included. I added the include to make the project build." This reverts commit 1662c21.
bobluppes
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Hi @FlorianXXIV, thanks for adding this, LGTM!
In the future I think we should add a test in the release CI to ensure that the project can be included using FetchContent. In general I would see this as a larger topic as the installation workflow for users could be streamlined 😅
This is a really nice step in that direction though! Please let me know if you continue to encounter issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use FetchContent for CMake to install graaflib but it didn't work, after some testing I decided to create a fork.
I made a new interface with add_library and added the include directory over target_include_directories, when using FetchContent with these modifications, including graaflib worked.
I also made sure I could build and test the project so that this didn't break stuff, and I got a build error telling me that the tarjan test used std::sort as an unknown target, I added an include for in tarjan.h to make the project build and the tests ran at 100%
I'm not really acquainted with how you properly write CMakeList files so if there are any issues feel free to tell me.