Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: change verifiedValidatorNum param of getFinalizedHeader API to -3 #254

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
+3 −1
Draft

op-node: change verifiedValidatorNum param of getFinalizedHeader API to -3 #254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d36df55
op-node: change verifiedValidatorNum to 8 temporarily
bnoieh Jan 6, 2025
69e8c4f
op-node: change verifiedValidatorNum param of getFinalizedHeader API …
bnoieh Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion op-service/sources/eth_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ func (s *EthClient) InfoByLabel(ctx context.Context, label eth.BlockLabel) (eth.
func (s *EthClient) BSCInfoByLabel(ctx context.Context, label eth.BlockLabel) (eth.BlockInfo, error) {
// can't hit the cache when querying the head due to reorgs / changes.
if label == eth.Finalized {
return s.bscFinalizedHeader(ctx, 21)
// FIXME set verifiedValidatorNum to -3 before release, set it to 8 temporarily for hotfix
// refs: https://github.com/bnb-chain/bsc/pull/2844
return s.bscFinalizedHeader(ctx, 8)
}
return s.headerCall(ctx, "eth_getBlockByNumber", label)
}
Expand Down
Loading