Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: change verifiedValidatorNum param of getFinalizedHeader API to -3 #254

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Jan 6, 2025

Description

change verifiedValidatorNum to -3 to automatically adapt BSC network validators

Rationale

validators of BSC network may change, and BSC getFinalizedHeader API support a new feature to automatically adapt this change, you can refer to bnb-chain/bsc#2844

we make this update to follow the new feature

Example

n/a

Changes

change verifiedValidatorNum to -3 to automatically adapt BSC network validators

@github-actions github-actions bot requested review from redhdx and welkin22 January 6, 2025 09:40
redhdx
redhdx previously approved these changes Jan 6, 2025
@bnoieh bnoieh changed the title op-node: change verifiedValidatorNum to 8 temporarily op-node: change verifiedValidatorNum param of getFinalizedHeader API to -3 Jan 7, 2025
@owen-reorg owen-reorg marked this pull request as draft January 15, 2025 16:27
@owen-reorg
Copy link
Collaborator

we have released hotfix image for this, and will use another solution after BSC refactor the API.
Turned the PR into draft for now, and we'll close it when all fixes are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants