Txpool optimization: filter out staled transactions of "nonce too low" when providing all pending list to miner #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepare for v0.5.2 release
prepare for v0.5.3 release
prepare for v0.5.4 release
This reverts commit 4ccfc35.
… but not 0 add more logs and metrics
bnoieh
reviewed
Jan 4, 2025
Comment on lines
+632
to
+635
| // TODO need to confirm | ||
| defer func(t0 time.Time) { | ||
| getPendingDurationTimer.Update(time.Since(t0)) | ||
| }(time.Now()) |
Comment on lines
+650
to
+652
| currBlockDuration time.Duration = 0 | ||
| currHeaderDuration time.Duration = 0 | ||
| txHashesDuration time.Duration = 0 |
There was a problem hiding this comment.
we could remove the debug duration to keep code clean if we confirmed there's no perf issue here
| @@ -1296,7 +1296,7 @@ func (w *worker) fillTransactions(interrupt *atomic.Int32, env *environment) err | |||
| pendingBlobTxs := w.eth.TxPool().Pending(filter) | |||
|
|
|||
| packFromTxpoolTimer.UpdateSince(start) | |||
| log.Debug("packFromTxpoolTimer", "duration", common.PrettyDuration(time.Since(start)), "hash", env.header.Hash(), "txs", len(pendingPlainTxs)) | |||
| log.Debug("packFromTxpoolTimer", "duration", common.PrettyDuration(time.Since(start)), "hash", env.header.Hash()) | |||
There was a problem hiding this comment.
why delete "txs" log here, it's useful when debug i think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We got a lot of "nonce too low" transactions after the optimization of #85, and they would be re-executed in the EVM, which wasted too much CPU resources. So we removed them before giving out the whole pending list of txpool.